Skip to content

Adapt to use assert raises #7670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KumoLiu merged 2 commits into from
Apr 19, 2024
Merged

Adapt to use assert raises #7670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85e771c
adapt to use assert raises
freddiewanah Apr 18, 2024
96da4ec
Merge branch 'dev' into adapt-assert-raises
KumoLiu Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/test_decathlondataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,14 @@ def _test_dataset(dataset):
self.assertDictEqual(properties["labels"], {"0": "background", "1": "Anterior", "2": "Posterior"})

shutil.rmtree(os.path.join(testing_dir, "Task04_Hippocampus"))
try:
with self.assertRaisesRegex(RuntimeError, "^Cannot find dataset directory"):
DecathlonDataset(
root_dir=testing_dir,
task="Task04_Hippocampus",
transform=transform,
section="validation",
download=False,
)
except RuntimeError as e:
print(str(e))
self.assertTrue(str(e).startswith("Cannot find dataset directory"))


if __name__ == "__main__":
Expand Down
5 changes: 1 addition & 4 deletions tests/test_mednistdataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,8 @@ def _test_dataset(dataset):
self.assertEqual(data[0]["class_name"], "AbdomenCT")
self.assertEqual(data[0]["label"], 0)
shutil.rmtree(os.path.join(testing_dir, "MedNIST"))
try:
with self.assertRaisesRegex(RuntimeError, "^Cannot find dataset directory"):
MedNISTDataset(root_dir=testing_dir, transform=transform, section="test", download=False)
except RuntimeError as e:
print(str(e))
self.assertTrue(str(e).startswith("Cannot find dataset directory"))


if __name__ == "__main__":
Expand Down
9 changes: 4 additions & 5 deletions tests/test_monai_utils_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,12 +92,11 @@ def test_run_cmd(self):
cmd2 = "-c"
cmd3 = 'import sys; print("\\tThis is on stderr\\n", file=sys.stderr); sys.exit(1)'
os.environ["MONAI_DEBUG"] = str(True)
try:
with self.assertRaises(RuntimeError) as cm:
run_cmd([cmd1, cmd2, cmd3], check=True)
except RuntimeError as err:
self.assertIn("This is on stderr", str(err))
self.assertNotIn("\\n", str(err))
self.assertNotIn("\\t", str(err))
self.assertIn("This is on stderr", str(cm.exception))
self.assertNotIn("\\n", str(cm.exception))
self.assertNotIn("\\t", str(cm.exception))


if __name__ == "__main__":
Expand Down
4 changes: 1 addition & 3 deletions tests/test_tciadataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def _test_dataset(dataset):
)[0]

shutil.rmtree(os.path.join(testing_dir, collection))
try:
with self.assertRaisesRegex(RuntimeError, "^Cannot find dataset directory"):
TciaDataset(
root_dir=testing_dir,
collection=collection,
Expand All @@ -117,8 +117,6 @@ def _test_dataset(dataset):
download=False,
val_frac=val_frac,
)
except RuntimeError as e:
self.assertTrue(str(e).startswith("Cannot find dataset directory"))


if __name__ == "__main__":
Expand Down