Always convert input to C-order in distance_transform_edt #7675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Nic-Ma
approved these changes
Apr 19, 2024
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Looks good to me.
Please ensure the performance of related transforms is not affected.
Thanks.
ericspod
reviewed
Apr 22, 2024
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
…tance_transform_edt Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Contributor
Author
|
/build |
ericspod
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7660
indices_may not always be a shallow copy for F-order input as it constantly converts to C-orderMONAI/monai/transforms/utils.py
Line 2209 in ffd4454
MONAI/monai/utils/type_conversion.py
Line 262 in ffd4454
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.