Add function in monai.transforms.utils.py #7712

ytl0623 · 2024-04-25T09:44:18Z

Description

Combined map_classes_to_indices and generate_label_classes_crop_centers to a single function map_and_generate_sampling_centers in monai.transforms.utils.py.

Types of changes

Non-breaking change (fix or new feature that would not break existing functionality).
Breaking change (fix or new feature that would cause existing functionality to change).
New tests added to cover the changes.
Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
In-line docstrings updated.
Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623 · 2024-04-25T12:47:31Z

cc @Yu0610

ytl0623 · 2024-04-25T19:18:48Z

Hi @KumoLiu and @ericspod, Could you please help me review the PR or give some tips to solve the issue?

Thanks in advance!

monai/transforms/utils.py

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

Signed-off-by: ytl0623 <david89062388@gmail.com>

for more information, see https://pre-commit.ci

KumoLiu · 2024-04-28T03:46:09Z

Hi @ytl0623, thanks for the quick update. Please take a look at the ci error. Thanks!
https://github.com/Project-MONAI/MONAI/actions/runs/8861728836/job/24333913325?pr=7712#step:8:12539

monai/transforms/utils.py

tests/test_map_and_generate_sampling_centers.py

monai/transforms/utils.py

Co-authored-by: Yu <146002968+Yu0610@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

for more information, see https://pre-commit.ci

Co-authored-by: Yu <146002968+Yu0610@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

Signed-off-by: ytl0623 <david89062388@gmail.com>

for more information, see https://pre-commit.ci

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623

OK

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623 · 2024-05-14T14:38:48Z

Hi @KumoLiu and @ericspod,

@Yu0610 and I just added a unit test and modified some bugs.
Please help us review the codes.

Thanks in advance!

monai/transforms/utils.py

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

for more information, see https://pre-commit.ci

Signed-off-by: ytl0623 <david89062388@gmail.com>

monai/transforms/utils.py

ericspod

I will approve now but there's two minor comments I made that should be looked at, otherwise it looks good now.

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623 · 2024-05-17T13:25:20Z

Hi, @ericspod and @KumoLiu
Please review my code if you have free time.
Thank you very much!

ytl0623 · 2024-05-19T11:43:03Z

Hi @KumoLiu,
Could you please help review codes?
Thanks a lot!

KumoLiu · 2024-05-21T06:30:06Z

/build

ytl0623 force-pushed the fix-issue-6704 branch 4 times, most recently from 63220ae to 0ee18a7 Compare April 25, 2024 10:48

Fixes Project-MONAI#6704

a78c5a6

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623 force-pushed the fix-issue-6704 branch from 0ee18a7 to a78c5a6 Compare April 25, 2024 10:58

KumoLiu reviewed Apr 26, 2024

View reviewed changes

monai/transforms/utils.py Show resolved Hide resolved

ericspod reviewed Apr 26, 2024

View reviewed changes

monai/transforms/utils.py Outdated Show resolved Hide resolved

ericspod reviewed Apr 26, 2024

View reviewed changes

monai/transforms/utils.py Show resolved Hide resolved

ericspod reviewed Apr 26, 2024

View reviewed changes

monai/transforms/utils.py Outdated Show resolved Hide resolved

vgrau98 mentioned this pull request Apr 27, 2024

Genai SA block integration #7720

Closed

7 tasks

ytl0623 and others added 4 commits April 28, 2024 00:26

Merge branch 'Project-MONAI:dev' into fix-issue-6704

4797043

Update monai/transforms/utils.py

f04a29e

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

Add a unittest and modify few codes.

7a31661

Signed-off-by: ytl0623 <david89062388@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

e66ae71

for more information, see https://pre-commit.ci

Yu0610 reviewed Apr 30, 2024

View reviewed changes

monai/transforms/utils.py Outdated Show resolved Hide resolved

Yu0610 reviewed May 14, 2024

View reviewed changes

ytl0623 and others added 8 commits May 14, 2024 18:15

Merge branch 'Project-MONAI:dev' into fix-issue-6704

df0f0d0

Apply suggestions from code review

a06511b

Co-authored-by: Yu <146002968+Yu0610@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

30d4876

for more information, see https://pre-commit.ci

Update monai/transforms/utils.py

535675d

Co-authored-by: Yu <146002968+Yu0610@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

import copy

656f56a

Signed-off-by: ytl0623 <david89062388@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

32c888d

for more information, see https://pre-commit.ci

import copy

9602d3a

Signed-off-by: ytl0623 <david89062388@gmail.com>

remove backup file :")

12e5881

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623 commented May 14, 2024

View reviewed changes

problem solved: Imports are incorrectly sorted and/or formatted.

e2641d4

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623 added 4 commits May 14, 2024 20:38

Reformat utils.py

639022c

Signed-off-by: ytl0623 <david89062388@gmail.com>

solve utils.py line: 388 too long.

eeae642

Signed-off-by: ytl0623 <david89062388@gmail.com>

Solved import error.

8ba5c7e

Signed-off-by: ytl0623 <david89062388@gmail.com>

Add function in _init_.py

d3ba184

Signed-off-by: ytl0623 <david89062388@gmail.com>

ericspod reviewed May 15, 2024

View reviewed changes

monai/transforms/utils.py Outdated Show resolved Hide resolved

ytl0623 and others added 3 commits May 15, 2024 20:03

Update monai/transforms/utils.py

f1f9a80

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

4ec2b64

for more information, see https://pre-commit.ci

Reformatted utils.py

dbc86e4

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623 force-pushed the fix-issue-6704 branch from e3cdde6 to dbc86e4 Compare May 15, 2024 12:25

ytl0623 added 2 commits May 16, 2024 16:23

Merge branch 'dev' into fix-issue-6704

7a8c7cd

20240516

f599cbe

Signed-off-by: ytl0623 <david89062388@gmail.com>

ytl0623 mentioned this pull request May 16, 2024

matplotlib 3.9.0 has no attribute 'get_cmap #7776

Closed

ytl0623 requested review from KumoLiu and ericspod May 17, 2024 03:56

Merge branch 'dev' into fix-issue-6704

2259678

ericspod reviewed May 17, 2024

View reviewed changes

monai/transforms/utils.py Outdated Show resolved Hide resolved

ericspod reviewed May 17, 2024

View reviewed changes

monai/transforms/utils.py Outdated Show resolved Hide resolved

ericspod approved these changes May 17, 2024

View reviewed changes

ytl0623 and others added 4 commits May 17, 2024 19:50

Merge branch 'dev' into fix-issue-6704

e394797

Update utils.py

943708e

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

Update utils.py

58ea019

Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: ytl0623 <david89062388@gmail.com>

Fix long line

317fc06

Signed-off-by: ytl0623 <david89062388@gmail.com>

Merge branch 'dev' into fix-issue-6704

6ba0a04

ericspod approved these changes May 17, 2024

View reviewed changes

Merge branch 'dev' into fix-issue-6704

53f472b

KumoLiu merged commit 244148d into Project-MONAI:dev May 21, 2024

Add function in monai.transforms.utils.py #7712

Add function in monai.transforms.utils.py #7712

Uh oh!

Conversation

ytl0623 commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Uh oh!

ytl0623 commented Apr 25, 2024

Uh oh!

ytl0623 commented Apr 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KumoLiu commented Apr 28, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ytl0623 left a comment

Choose a reason for hiding this comment

Uh oh!

ytl0623 commented May 14, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ericspod left a comment

Choose a reason for hiding this comment

Uh oh!

ytl0623 commented May 17, 2024

Uh oh!

ytl0623 commented May 19, 2024

Uh oh!

KumoLiu commented May 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ytl0623 commented Apr 25, 2024 •

edited

Loading