Skip to content

Conversation

@Pkaps25
Copy link
Contributor

@Pkaps25 Pkaps25 commented May 8, 2024

Fixes #7653 .

Description

Includes an act parameter to ResNet and its submodules to allow for passing the inplace param.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Peter Kaplinsky added 5 commits May 8, 2024 14:38
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
I, Peter Kaplinsky <peterkaplinsky@gmail.com>, hereby add my Signed-off-by to this commit: 231ac39

Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
Signed-off-by: Peter Kaplinsky <peterkaplinsky@gmail.com>
@Pkaps25
Copy link
Contributor Author

Pkaps25 commented May 8, 2024

@KumoLiu looking for review

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, looks good to me.

@KumoLiu
Copy link
Contributor

KumoLiu commented May 9, 2024

/build

@KumoLiu KumoLiu requested review from Nic-Ma and ericspod May 9, 2024 05:15
@Pkaps25 Pkaps25 marked this pull request as ready for review May 9, 2024 12:06
@KumoLiu KumoLiu merged commit 258f56d into Project-MONAI:dev May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include option to set inplace=True for resnet

2 participants