Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented May 20, 2024

Description

  • skip release_tag_docker for resource issue
  • increase tolerance for tests/test_clip_intensity_percentiles.py
  • skip tests/test_regularization.py for non-deterministic

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu and others added 2 commits May 21, 2024 00:56
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 20, 2024

/build

@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 20, 2024

/build

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a fix, what was the issue with generating the Docker release?

@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 20, 2024

Looks good for a fix, what was the issue with generating the Docker release?

This one, github limited resource issue.
#7449

@KumoLiu KumoLiu enabled auto-merge (squash) May 20, 2024 17:45
@KumoLiu KumoLiu merged commit 96bfda0 into Project-MONAI:dev May 20, 2024
@KumoLiu KumoLiu deleted the skip-test branch May 21, 2024 03:15
KumoLiu added a commit to KumoLiu/MONAI that referenced this pull request May 21, 2024
- skip release_tag_docker for resource issue
- increase tolerance for tests/test_clip_intensity_percentiles.py
- skip tests/test_regularization.py for non-deterministic

<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants