Integrating a Tailored Diffusion U-Net Model into Generative Model Application #7867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
for more information, see https://pre-commit.ci
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
…0122/MONAI into fix-issue-7858-add-unet
for more information, see https://pre-commit.ci
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
for more information, see https://pre-commit.ci
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
for more information, see https://pre-commit.ci
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: Dong Yang <yangd05@Dongs-MacBook-Pro.local>
for more information, see https://pre-commit.ci
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Collaborator
Author
KumoLiu
reviewed
Jun 25, 2024
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the PR, few comments inline.
monai/apps/generation/maisi/networks/diffusion_model_unet_maisi.py
Outdated
Show resolved
Hide resolved
monai/apps/generation/maisi/networks/diffusion_model_unet_maisi.py
Outdated
Show resolved
Hide resolved
monai/apps/generation/maisi/networks/diffusion_model_unet_maisi.py
Outdated
Show resolved
Hide resolved
KumoLiu
reviewed
Jun 25, 2024
monai/apps/generation/maisi/networks/diffusion_model_unet_maisi.py
Outdated
Show resolved
Hide resolved
monai/apps/generation/maisi/networks/diffusion_model_unet_maisi.py
Outdated
Show resolved
Hide resolved
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
ericspod
reviewed
Jun 29, 2024
monai/apps/generation/maisi/networks/diffusion_model_unet_maisi.py
Outdated
Show resolved
Hide resolved
monai/apps/generation/maisi/networks/diffusion_model_unet_maisi.py
Outdated
Show resolved
Hide resolved
monai/apps/generation/maisi/networks/diffusion_model_unet_maisi.py
Outdated
Show resolved
Hide resolved
Signed-off-by: dongyang0122 <don.yang.mech@gmail.com>
Contributor
|
/build |
ericspod
approved these changes
Jul 2, 2024
Member
ericspod
left a comment
ericspod
left a comment
There was a problem hiding this comment.
I think this is good now. I'm not sure if referencing a specific commit in requirements-dev.txt is a good idea, we can do another "bug-fix" release of GenerativeModels later if this is a problem.
| "generative.networks.nets.diffusion_model_unet", name="get_timestep_embedding" | ||
| ) | ||
| get_up_block, has_get_up_block = optional_import("generative.networks.nets.diffusion_model_unet", name="get_up_block") | ||
| xformers, has_xformers = optional_import("xformers") |
Contributor
There was a problem hiding this comment.
Hi @dongyang0122 @KumoLiu , I think we need to either add xformers into our requirements-dev, or remove this from the code.
P.S. As far as I know, the installation of xformers is pretty nasty with nvidia DLFW pytorch container. It need to build from source and the compilation will somehow break/restart the machine if it hardwares are low profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7858.
Integrating a tailored diffusion U-Net model into the generative model application to improve the production of high-dimensional 3D images, specifically sized at 512 x 512 x 512.
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.