Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 17, 2024

Fixes #7923

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu added 2 commits July 17, 2024 19:09
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested review from Nic-Ma and ericspod July 17, 2024 11:13
@ericspod
Copy link
Member

The bias_downsample value should be bool everywhere from what I gather, however in get_medicalnet_pretrained_resnet_args there's still code treating it like an int, should this be revised as well?

KumoLiu added 2 commits July 17, 2024 22:24
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 17, 2024

The bias_downsample value should be bool everywhere from what I gather, however in get_medicalnet_pretrained_resnet_args there's still code treating it like an int, should this be revised as well?

Yes, I revised all of them in the latest commit. Could you please help review it again? Thanks!

KumoLiu and others added 2 commits July 17, 2024 23:37
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested a review from ericspod July 18, 2024 07:03
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jul 18, 2024

/build

@ericspod ericspod merged commit 46e2b0e into Project-MONAI:dev Jul 18, 2024
@KumoLiu KumoLiu deleted the resnet branch July 19, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pretrained weights incompatibility for resnet10

2 participants