Skip to content

Ensure synchronization by adding cuda.synchronize() #8058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KumoLiu merged 3 commits into from
Aug 30, 2024
Merged

Ensure synchronization by adding cuda.synchronize() #8058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31d5f91
fix #8054
KumoLiu Aug 30, 2024
8db28c9
fix
KumoLiu Aug 30, 2024
872457d
add cuda check
KumoLiu Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions monai/networks/layers/filtering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ def forward(ctx, input, spatial_sigma=5, color_sigma=0.5, fast_approx=True):
ctx.cs = color_sigma
ctx.fa = fast_approx
output_data = _C.bilateral_filter(input, spatial_sigma, color_sigma, fast_approx)
if torch.cuda.is_available():
torch.cuda.synchronize()
return output_data

@staticmethod
Expand Down Expand Up @@ -139,7 +141,8 @@ def forward(ctx, input_img, sigma_x, sigma_y, sigma_z, color_sigma):
do_dsig_y,
do_dsig_z,
)

if torch.cuda.is_available():
torch.cuda.synchronize()
return output_tensor

@staticmethod
Expand Down Expand Up @@ -301,7 +304,8 @@ def forward(ctx, input_img, guidance_img, sigma_x, sigma_y, sigma_z, color_sigma
do_dsig_z,
guidance_img,
)

if torch.cuda.is_available():
torch.cuda.synchronize()
return output_tensor

@staticmethod
Expand Down
3 changes: 2 additions & 1 deletion monai/transforms/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2512,6 +2512,7 @@ def distance_transform_edt(
block_params=block_params,
float64_distances=float64_distances,
)
torch.cuda.synchronize()
else:
if not has_ndimage:
raise RuntimeError("scipy.ndimage required if cupy is not available")
Expand Down Expand Up @@ -2545,7 +2546,7 @@ def distance_transform_edt(

r_vals = []
if return_distances and distances_original is None:
r_vals.append(distances)
r_vals.append(distances_ if use_cp else distances)
if return_indices and indices_original is None:
r_vals.append(indices)
if not r_vals:
Expand Down