Skip to content

Fix dtype bug in ScaleIntensityRangePercentile #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KumoLiu merged 2 commits into from
Sep 26, 2024
Merged

Fix dtype bug in ScaleIntensityRangePercentile #8109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5974b2
fix #8108
KumoLiu Sep 25, 2024
761e99d
fix flake8
KumoLiu Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion monai/transforms/intensity/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,7 +1411,7 @@ def __call__(self, img: NdarrayOrTensor) -> NdarrayOrTensor:
else:
img_t = self._normalize(img=img_t)

return convert_to_dst_type(img_t, dst=img)[0]
return convert_to_dst_type(img_t, dst=img, dtype=self.dtype)[0]


class MaskIntensity(Transform):
Expand Down
2 changes: 2 additions & 0 deletions tests/test_scale_intensity_range_percentiles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import unittest

import numpy as np
import torch

from monai.transforms.intensity.array import ScaleIntensityRangePercentiles
from tests.utils import TEST_NDARRAYS, NumpyImageTestCase2D, assert_allclose
Expand All @@ -34,6 +35,7 @@ def test_scaling(self):
scaler = ScaleIntensityRangePercentiles(lower=lower, upper=upper, b_min=b_min, b_max=b_max, dtype=np.uint8)
for p in TEST_NDARRAYS:
result = scaler(p(img))
self.assertEqual(result.dtype, torch.uint8)
assert_allclose(result, p(expected), type_test="tensor", rtol=1e-4)

def test_relative_scaling(self):
Expand Down