Remove deprecated functionality for v1.5 #8430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove deprecated functionality Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Jose1654
approved these changes
Apr 29, 2025
ericspod
approved these changes
Apr 29, 2025
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Contributor
Author
|
/build |
Contributor
Author
|
Error log: |
Member
|
Hi @KumoLiu can you set |
KumoLiu
added a commit
to Project-MONAI/research-contributions
that referenced
this pull request
May 9, 2025
Remove deprecated `img_size` args in `SwinUNETR` Add `allow_smaller=True` in CropForeground / CropForegroundd since default value has been changed Project-MONAI/MONAI#8430 --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Contributor
Author
Hi @ericspod, it should be fixed by this PR: Project-MONAI/research-contributions#416. |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Contributor
Author
|
/build |
Contributor
Author
|
Identify the issue: There’s a dependency between this one and #8443. They must be merged simultaneously. If the changes to core aren’t merged, the algo adjustments won’t function properly. |
Member
nishanthta
pushed a commit
to nishanthta/monai-dae
that referenced
this pull request
Sep 9, 2025
Remove deprecated `img_size` args in `SwinUNETR` Add `allow_smaller=True` in CropForeground / CropForegroundd since default value has been changed Project-MONAI/MONAI#8430 --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove deprecated functionality
Part of #8421
Description
Removed Functionality:
compute_percent_hausdorff_distance. Usecompute_hausdorff_distancewith thepercentileargument instead.net_name,net_kwargs, andreturn_state_dictarguments fromload(). Use themodelargument for network instantiation.workflowargument fromBundleWorkflowandConfigWorkflow. Useworkflow_typeinstead.img_sizeargument fromSwinUNETR. Input size checks are now performed duringforward().Default Value Changes:
GeneralizedDiceScore: Changed defaultreductionfromMEAN_BATCHtoMEAN.CropForeground/CropForegroundd: Changed defaultallow_smallerfromTruetoFalse.get_mask_edges: Changed defaultalways_return_as_numpyfromTruetoFalse.generate_spatial_bounding_box: Changed defaultallow_smallerfromTruetoFalse.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.