Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the core codebase now requires at least torch 1.6 Fixes Project-MONAI#509
wyli
approved these changes
Nov 28, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
there are two notebooks with the amp
- acceleration/automatic_mixed_precision.ipynb
- modules/batch_output_transform.ipynb
I guess it's a minor issue and keeping them is a good reminder of the feature availability
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
…t-MONAI#1072) Fixes Project-MONAI#509 ### Description Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) because the core codebase now requires at least torch 1.6. See also [here](Project-MONAI/MONAI#3353) ### Checks - [x] Notebook runs automatically `./runner [-p <regex_pattern>]`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
Description
Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) because the core codebase now requires at least torch 1.6. See also here
Checks
./runner [-p <regex_pattern>]