Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Feb 17, 2023

Fixes #1219 (comment)

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wyli wyli requested a review from mingxin-zheng February 17, 2023 06:26
@wyli
Copy link
Contributor Author

wyli commented Feb 17, 2023

It doesn't pass the ci #1221 so indeed the noqa line is currently in use @mingxin-zheng

@wyli wyli closed this Feb 17, 2023
@wyli wyli deleted the wyli-patch-1 branch February 17, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants