Skip to content

Conversation

@KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 19, 2022

Fixes Project-MONAI/MONAI#4878

Description

HoVerNet training tutorial

  • ignite version pipeline

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

KumoLiu and others added 24 commits July 21, 2022 10:22
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

KumoLiu and others added 5 commits October 19, 2022 14:09
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@bhashemian
Copy link
Member

Hi @KumoLiu, since we only have ignite based pipelines here, could you please update the name of the files to evaluation.py and training.py? thanks

KumoLiu and others added 7 commits November 23, 2022 10:16
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
update README

Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu mentioned this pull request Nov 24, 2022
1 task
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Copy link

@JHancox JHancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the CV2 comment I made, it looks good.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@OmarAshkar
Copy link

Hi @KumoLiu Thanks for your great work. I have been looking for the best hovernet implementation for my case. However, I have a comment here on using .mat format.https://github.com/KumoLiu/tutorials/blob/1b9f64d3a32fa08d37048dab282bf8e82c84aed7/pathology/hovernet/prepare_patches.py#L20

My WSI is huge and could not be accommodated in .mat format. Also, I find this format to be unintutive to a python user. So, can we replace it with .npy source or wrap it to give a flexiblity to choose the best format?

@JHancox
Copy link

JHancox commented Dec 2, 2022

Hi @KumoLiu Thanks for your great work. I have been looking for the best hovernet implementation for my case. However, I have a comment here on using .mat format.https://github.com/KumoLiu/tutorials/blob/1b9f64d3a32fa08d37048dab282bf8e82c84aed7/pathology/hovernet/prepare_patches.py#L20

My WSI is huge and could not be accommodated in .mat format. Also, I find this format to be unintutive to a python user. So, can we replace it with .npy source or wrap it to give a flexiblity to choose the best format?

Hi @OmarAshkar - Thanks for your interest in Monai and Hovernet. So the .mat format is being used here to load annotations that are part of the ConSep dataset. Each .mat file will contain annotations for the nuclei. There should be no need to present your WSI in .mat format. If you want to run inference on your WSI, you don't need to use this script at all. If you do wish to train Hovernet on your own data, then you would need to prepare the data and annotations in a format of your choosing. You could certainly use .npy for that. Hope that helps.

@OmarAshkar
Copy link

Thanks @JHancox! yes I want to train my own data. I really wanted to extract the batches first instead of figuring out how to customize it for hovernet architecture. But I understand I think I will manipulate the script to my taste.

Thanks!

@wyli wyli merged commit 873b0f9 into Project-MONAI:main Dec 8, 2022
@KumoLiu KumoLiu deleted the hovernet-train branch December 8, 2022 13:23
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Fixes Project-MONAI/MONAI#4878

### Description
HoVerNet training tutorial
- [x] ignite version pipeline

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pathology HoVerNet: Build the training pipeline

7 participants