This repository was archived by the owner on Jun 8, 2024. It is now read-only.
Conversation
lbud
pushed a commit
that referenced
this pull request
Apr 29, 2015
Improve test coverage + node_osrm bugs uncovered by coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87:
This improves test coverage and also fixes a number of issues uncovered in doing so:
Also closes #94 and clarifies constructor by accepting a params argument in the constructor (but retains the option to only pass a path string so as to maintain backwards compatibility).
These changes were pulled out of #91 but need to wait on that PR to merge (in order to build on coveralls).
cc @springmeyer @TheMarex