Skip to content

Conversation

@xFutte
Copy link
Member

@xFutte xFutte commented Jan 5, 2024

Accidentially introduced a performance issue in #c171964 by subscribing to a store multiple times. Fixed by subscribing once and adding the value of the subscription to a reactive declaration.

@xFutte xFutte requested a review from MonkeyWhisper January 6, 2024 13:37
@xFutte xFutte changed the title Fixed performance issue introduced in #c171964 Fixed memory leak Jan 6, 2024
@MonkeyWhisper MonkeyWhisper merged commit 293108a into main Jan 9, 2024
@xFutte xFutte deleted the fix/store-subscription branch January 16, 2024 19:20
mafewtm added a commit to OdysseyRP/ps-dispatch that referenced this pull request Mar 22, 2024
* Fixed memory leak (Project-Sloth#251)

* Fixed performance issue introduced in c171964

* Updates store with IS_MARGIN_RIGHT value

* Bumped node modules for security (Project-Sloth#252)

* Bumped dependency versions

* Rebuild with new vite version

* 2.1.5

* Update alerts.lua (Project-Sloth#255)

Fix an issue where the data are not get when the vehicle argument is passed directly through the exports.

* Uppdated Readme + changed custom alert in alerts.lua for more help (Project-Sloth#254)

* Update alerts.lua

* Update README.md

* Update alerts.lua

---------

Co-authored-by: MonkeyWhisper <82112471+MonkeyWhisper@users.noreply.github.com>

* 2.1.6

* Minor changes fr.json (Project-Sloth#260)

Modified some entries to make it more "French". Also some clarity changes.

* Fixed GetVehicleColours (Project-Sloth#266)

Changed GetVehicleColor to GetVehicleColours.

GetVehicleColor: Get RGB Color.
GetVehicleColours: Get Primary & Secondary Color.

* Locales fix and female/male fix (Project-Sloth#262)

* Update utils.lua

* added male/female

added male/female

* 2.1.7

---------

Co-authored-by: Futte <xFutte@gmail.com>
Co-authored-by: MonkeyWhisper <82112471+MonkeyWhisper@users.noreply.github.com>
Co-authored-by: LeZach <48424078+zf-development@users.noreply.github.com>
Co-authored-by: LeSiiN <103898231+LeSiiN@users.noreply.github.com>
Co-authored-by: ViorisE <viorise@liferp.gg>
Co-authored-by: xSamiVS <samtaiebc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants