Changed more events

[lenzh]

with the new QB updates inventory events now needs to be called different

[xFutte]

Code looks good, just needs to test that everything still works after the renaming.

[lenzh]

if im correct this will be working with all latest qb updates

[MonkeyWhisper]

What did you approve @Max-Storm-03? You got no clue what is going on.

[FoxThirtySix]

Hi there! Having a strange issue still with weapon attachments not being able to be viewed in inventory. With the latest core updates and up-to-date dependencies, I am still having this issue. Below are the steps I'm doing to get the error, at the request of Lenzh.

• Give myself a weapon (any weapon).
• Give myself a weapon attachment (any attachment).
• "Use" the weapon attachment on the weapon, attaching it.
• Click on the weapon in its inventory slot to view attachments, and I receive the following error

[xFutte]

Hi there! Having a strange issue still with weapon attachments not being able to be viewed in inventory. With the latest core updates and up-to-date dependencies, I am still having this issue. Below are the steps I'm doing to get the error, at the request of Lenzh.

• Give myself a weapon (any weapon).
• Give myself a weapon attachment (any attachment).
• "Use" the weapon attachment on the weapon, attaching it.
• Click on the weapon in its inventory slot to view attachments, and I receive the following error

Is this while testing this PR?

[FoxThirtySix]

Hi there! Having a strange issue still with weapon attachments not being able to be viewed in inventory. With the latest core updates and up-to-date dependencies, I am still having this issue. Below are the steps I'm doing to get the error, at the request of Lenzh.

• Give myself a weapon (any weapon).
• Give myself a weapon attachment (any attachment).
• "Use" the weapon attachment on the weapon, attaching it.
• Click on the weapon in its inventory slot to view attachments, and I receive the following error

Is this while testing this PR?

I had this before and after, yes.

[lenzh]

issue should now be fixed @FoxThirtySix

[xFutte]

Please serialize the data we get through the event to prevent exploits.

[xFutte]

Inserting html like this directly on an HTML element can be quite dangerous for exploding the code. A better solution would be to build up a couple of elements and then appending them to the item-info-description element. It could look somewhat like this:

const description = document.createElement("p");
const header = document.createElement("strong");
const value = document.createElement("span");

header.innerText = "Serial:";
value.innerText = item.info.ammo;
description.innerHTML = `${header} {value}`

document.querySelector(".item-info-description").appendChild(description)

You can then loop over all the values inside the itemData.info array to output them all. Requires a little fiddling with the code above.

[lenzh]

this was default code from the old ps-inv just made it compat with new qb-core