In #18 we fixed that OOF memberships, created an erroneous financial transaction.
At the end the issue was not solved for events.
I had already the following findings:
However for events this problem still remains. Because the parameter is_paylater is set false, a payment is created here:
https://github.com/civicrm/civicrm-core/blob/48e6e28f1af3023577e16437620fdf751c005d0b/CRM/Contribute/BAO/Contribution.php#L3183
because here:
https://github.com/civicrm/civicrm-core/blob/48e6e28f1af3023577e16437620fdf751c005d0b/CRM/Contribute/BAO/Contribution.php#L2950
My feelings say, that there need to be changes in the BAO/Contribution.php . But I'm still not very confident, with the code there, as it very long and complex.