bug/preserve light dom html entities in text nodes#182
Closed
thescientist13 wants to merge 2 commits intomasterfrom
Closed
bug/preserve light dom html entities in text nodes#182thescientist13 wants to merge 2 commits intomasterfrom
thescientist13 wants to merge 2 commits intomasterfrom
Conversation
Member
Author
|
confirmed that #178 seems to fix this issue completely as confirmed in ProjectEvergreen/greenwood#1376 😌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
ProjectEvergreen/greenwood#1375
Summary of Changes
TODO
>too? Others?<too?Regarding the second point above, it seems through the serialization process parse5 will even encode legitimate
<even when not using ourreplacefunction? 🤔{ value: '\n' + ' <h1>Hello from the server rendered users < page! 👋</h1>\n' + ' ' } { html: '\n' + ' <x-ctc>\n' + ' <h1>Hello from the server rendered users < page! 👋</h1>\n' + ' </x-ctc>\n' + ' ' }