Skip to content

config for ways to omit declarative shadow dom (lightMode)#19

Merged
thescientist13 merged 7 commits intomasterfrom
feature/issue-18-static-html-no-dsd-options
May 11, 2022
Merged

config for ways to omit declarative shadow dom (lightMode)#19
thescientist13 merged 7 commits intomasterfrom
feature/issue-18-static-html-no-dsd-options

Conversation

@thescientist13
Copy link
Copy Markdown
Member

@thescientist13 thescientist13 commented May 7, 2022

Related Issue

resolves #18

Summary of Changes

  1. Add config (lightMode) for omitting <template> tag for custom element renders

TODO

  1. Safari seems to be missing styles for some elements
    Details Screen Shot 2022-05-07 at 5 36 21 PM Screen Shot 2022-05-07 at 5 36 16 PM
  2. Add specs
  3. Add documentation
  4. Am I implementing / using includeShadowRoots correctly? I could read it two ways (might want to track as a new issue) - made a gist - verify / ensure proper serialization of shadow roots excluding closed shadow roots from getInnerHTML #16
    • literally does not render shadow roots at all
    • just doesn't render / return them in <template>
  5. Not sure if there is value in having a way to opt-out at the top level for this, like if your page is a custom element?
    Perhaps you want your page as light DOM, but still keep the shadow DOM for all nested children? Might want to make an issue to track. - verify / ensure proper serialization of shadow roots excluding closed shadow roots from getInnerHTML #16

@thescientist13 thescientist13 added documentation Improvements or additions to the website and / or documentation feature New feature or request question Further information is requested labels May 7, 2022
@thescientist13 thescientist13 self-assigned this May 7, 2022
@thescientist13 thescientist13 changed the title [DRAFT] config for various ways to omit declarative shadow dom config for ways to omit declarative shadow dom May 8, 2022
@thescientist13 thescientist13 changed the title config for ways to omit declarative shadow dom config for ways to omit declarative shadow dom (lightMode) May 8, 2022
@thescientist13 thescientist13 force-pushed the feature/issue-18-static-html-no-dsd-options branch from 0feffbb to 06233a3 Compare May 11, 2022 01:30
@thescientist13 thescientist13 merged commit 71cf93f into master May 11, 2022
@thescientist13 thescientist13 deleted the feature/issue-18-static-html-no-dsd-options branch May 11, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to the website and / or documentation feature New feature or request question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omit <template> from rendered declarative shadow dom (support static HTML workflows)

1 participant