Skip to content

style updates per request in issue #17#20

Merged
thescientist13 merged 1 commit into
masterfrom
update/header-footer-spacing-styles
May 11, 2022
Merged

style updates per request in issue #17#20
thescientist13 merged 1 commit into
masterfrom
update/header-footer-spacing-styles

Conversation

@aholtzman
Copy link
Copy Markdown
Member

NOTE: this PR covers the requested styling updates, though there were a11y issues seen - an audit & issue(s) should be done to address them.

Related Issue

checks one box on for issue #17 - styling change requested

Summary of Changes

  1. changed body display to flex from grid
  2. applied max-width & centering margin on main
  3. wrapped header content to maintain current alignment

@aholtzman aholtzman requested a review from thescientist13 May 7, 2022 23:26
@thescientist13 thescientist13 linked an issue May 8, 2022 that may be closed by this pull request
15 tasks
@thescientist13 thescientist13 mentioned this pull request May 8, 2022
15 tasks
Copy link
Copy Markdown
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

It definitely just needed a little more room to breath, so this is great.

Comment thread docs/index.js

<wcc-footer></wcc-footer>

</main>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 👀

@thescientist13 thescientist13 added the documentation Improvements or additions to the website and / or documentation label May 8, 2022
@thescientist13 thescientist13 force-pushed the update/header-footer-spacing-styles branch from e621ad6 to 8e51ea6 Compare May 11, 2022 01:21
@thescientist13 thescientist13 merged commit 9f12d4c into master May 11, 2022
@thescientist13 thescientist13 deleted the update/header-footer-spacing-styles branch May 11, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to the website and / or documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go Live checklist

2 participants