Skip to content

fix: #219 preserve JSX literal attribute expressions #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thescientist13 merged 1 commit into from
Jan 8, 2026
Merged

fix: #219 preserve JSX literal attribute expressions #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sandbox/components/counter-dsd.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ export default class CounterDsdTsx extends HTMLElement {
return (
<div style="width: 50%; margin: 0 auto; text-align: center;">
<button onclick={(this.count -= 1)}> -</button>
{/* `<img> tag here to make sure types work */}
<img width={10} />
<span>
You have clicked <span class="red">{count}</span> times
</span>
Expand Down
27 changes: 17 additions & 10 deletions src/jsx-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,17 +141,24 @@ function parseJsxElement(element, moduleContents = '') {
// xxx={allTodos.length} >
const { value } = attribute;
const { expression } = value;
const expressionType = expression.type;

if (expression.type === 'Identifier') {
string += ` ${name}=$\{${expression.name}}`;
}

if (expression.type === 'MemberExpression') {
if (expression.object.type === 'Identifier') {
if (expression.property.type === 'Identifier') {
string += ` ${name}=$\{${expression.object.name}.${expression.property.name}}`;
switch (expressionType) {
case 'Literal':
string += ` ${name}=${expression.raw}`;
break;
case 'Identifier':
string += ` ${name}=$\{${expression.name}}`;
break;
case 'MemberExpression':
if (expression.object.type === 'Identifier') {
if (expression.property.type === 'Identifier') {
string += ` ${name}=$\{${expression.object.name}.${expression.property.name}}`;
}
}
}
break;
default:
break;
}
}
} else {
Expand All @@ -161,7 +168,7 @@ function parseJsxElement(element, moduleContents = '') {
}
}

string += openingElement.selfClosing ? '/>' : '>';
string += openingElement.selfClosing ? ' />' : '>';

if (element.children.length > 0) {
element.children.forEach((child) => parseJsxElement(child, moduleContents));
Expand Down
9 changes: 6 additions & 3 deletions test/cases/tsx/src/badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,12 @@ export default class BadgeComponent extends HTMLElement {
const conditionalText = predicate ? ' 🥳' : '';

return (
<span class={conditionalClass}>
{count}
{conditionalText}
<span>
<img src="badge-icon.png" alt="Badge Icon" width={16} height={16} />
<span class={conditionalClass}>
{count}
{conditionalText}
</span>
</span>
);
}
Expand Down
13 changes: 12 additions & 1 deletion test/cases/tsx/tsx.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,23 @@ describe('Run WCC For ', function () {
// <wcc-badge count={completedTodos.length}></wcc-badge>
it('should handle a member expression', () => {
const badge = dom.window.document.querySelectorAll('wcc-badge')[0];
const span = badge.querySelectorAll('span')[0];
const span = badge.querySelectorAll('span span')[0];

expect(badge.getAttribute('count')).to.be.equal('0');
expect(span.getAttribute('class')).to.be.equal('unmet');
expect(span.textContent.trim()).to.be.equal('0');
});

// <img src="badge-icon.png" alt="Badge Icon" width={16} height={16} />
it('should preserve literal attribute expressions when using TS', () => {
const badge = dom.window.document.querySelectorAll('wcc-badge')[0];
const img = badge.querySelectorAll('span img')[0];

expect(img.getAttribute('src')).to.be.equal('badge-icon.png');
expect(img.getAttribute('alt')).to.be.equal('Badge Icon');
expect(img.getAttribute('width')).to.be.equal('16');
expect(img.getAttribute('height')).to.be.equal('16');
});
});

describe('Event Handling', () => {
Expand Down