Update class-wpdb.php to support NVARCHAR#516
Open
srutzky wants to merge 1 commit intoProjectNami:masterfrom
Open
Update class-wpdb.php to support NVARCHAR#516srutzky wants to merge 1 commit intoProjectNami:masterfrom
srutzky wants to merge 1 commit intoProjectNami:masterfrom
Conversation
Add "N" prefix to quoted string substitution when preparing SQL for execution. This will change string literals to be interpreted as NVARCHAR (i.e. Unicode / UTF-16) instead of an 8-bit encoding (which changes all characters not in the associated code page to "?"s).
|
Tested in 6.5.3 and appears to work without issue. |
|
Retested in 3.8.1 and working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #515 .
Add "N" prefix to quoted string substitution when preparing SQL for execution. This will change string literals to be interpreted as NVARCHAR (i.e. Unicode / UTF-16) instead of VARCHAR (i.e. an 8-bit encoding, which changes all characters not in the associated code page to "?"s).
PLEASE NOTE: I don't have time to test this fix. If it helps, there are some notes on what should be tested in PR #422 .