Skip to content

Fix fulfillBasicOrder alias encoding #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryanio merged 1 commit into from
Nov 12, 2025
Merged

Fix fulfillBasicOrder alias encoding #1819

ryanio merged 1 commit into from
Nov 12, 2025

Conversation

@ryanio
Copy link
Collaborator

@ryanio ryanio commented Nov 12, 2025

Summary

  • normalize fulfillBasicOrder alias emitted by fulfillment API so we always encode against the ABI fragment that exists in seaport-js
  • add regression test proving alias orders encode and send successfully

Fixes #1816

@ryanio ryanio force-pushed the fix-basic-order-event branch from cf15d9d to 74c2916 Compare November 12, 2025 23:32
@ryanio ryanio merged commit ba433ff into main Nov 12, 2025
8 checks passed
@ryanio ryanio deleted the fix-basic-order-event branch November 12, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid function name: fulfillBasicOrder_efficient_6GL6yc

2 participants

@ryanio