feat: add includeOptionalCreatorFees to fulfillOrder #1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add includeOptionalCreatorFees parameter to fulfill offer and fulfill listing endpoints. When set to true, optional creator fees will be included in the fulfillment. If creator fees are already required, this is a no-op. Defaults to false. Changes: - Add includeOptionalCreatorFees param to getFulfillListingPayload/getFulfillOfferPayload - Add includeOptionalCreatorFees param to generateFulfillmentData in OrdersAPI and OpenSeaAPI - Add includeOptionalCreatorFees param to fulfillOrder in FulfillmentManager and OpenSeaSDK - Update tests to cover new parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
includeOptionalCreatorFeesparameter to fulfill offer and fulfill listing endpoints.Description
When set to
true, optional creator fees will be included in the fulfillment. If creator fees are already required, this is a no-op. Defaults tofalse.Changes
includeOptionalCreatorFeesparam togetFulfillListingPayload/getFulfillOfferPayloadinsrc/orders/utils.tsincludeOptionalCreatorFeesparam togenerateFulfillmentDatainsrc/api/orders.tsandsrc/api/api.tsincludeOptionalCreatorFeesparam tofulfillOrderinsrc/sdk/fulfillment.tsandsrc/sdk.tsUsage
Testing
test/orders/utils.spec.ts