Fix: Use correct function for listing payment token cache #1831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listing payment token cache was incorrectly using getOfferPaymentToken() instead of getListingPaymentToken(). This caused the wrong token address to be cached for listings. This bug could lead to issues when listing payment tokens differ from offer payment tokens on certain chains.
Collaborator
|
thanks! |
ryanio
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Line 104 in
src/sdk.tsusesgetOfferPaymentToken()when it should usegetListingPaymentToken(). This is a copy-paste error from line 103.Problem
The wrong token address gets cached for listings. On chains where listing tokens differ from offer tokens (like ETH vs WETH on mainnet), this breaks the cache and could cause issues with listing operations.
Fix
getListingPaymentToken(this.chain)instead ofgetOfferPaymentToken(this.chain)getListingPaymentTokenThe rest of the codebase already uses these functions correctly - this was just a typo in the cache initialization.