fix: change Transaction.value type from number to string to prevent overflow #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verflow JavaScript's Number type can only safely represent integers up to 2^53-1. When the API returns large wei values (like NFT prices in wei), they can overflow and become negative values like -1617240366657743600. This fix changes Transaction.value type from number to string, which: - Prevents integer overflow for large wei values - Works with ethers.js which accepts strings as BigNumberish - Matches how the API should serialize large integer values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using
fulfillOrder, users encounter an overflow error:Root Cause
The
Transaction.valuefield insrc/orders/types.tsis typed asnumber, but JavaScript'sNumbertype can only safely represent integers up to 2^53 - 1 (9,007,199,254,740,991).When the API returns large wei values (like prices for NFTs), JSON parsing converts them to JavaScript numbers. Values exceeding the safe integer limit overflow and become incorrect/negative values.
Solution
Changed
Transaction.valuetype fromnumbertostring. This works because:BigNumberishfor transaction valuesTesting
This is a type-only change that prevents overflow when handling large transaction values in the
fulfillOrderflow.