Support SwiftPM #15
Merged
Support SwiftPM #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Any chance at getting this merged and a new tag created so that this project supports SPM? |
lstomberg
force-pushed
the
master
branch
2 times, most recently
from
6cdd8a9 to
ca6a32a
Compare
RomanPodymov
requested changes
Jun 12, 2024
|
|
||
| #if !os(tvOS) | ||
|
|
||
| public struct AnimationOptions: OptionSet { |
Contributor
There was a problem hiding this comment.
Hello @lstomberg
Why do you need to re-define PMKAnimationOptions?
Member
There was a problem hiding this comment.
Presumably for SwiftPM since it won't get the objective-c portions
Contributor
|
Hello @mxcl |
Member
|
Looks fine |
RomanPodymov
approved these changes
Sep 10, 2024
|
Hi, @RomanPodymov! Could you please make it work with the current PromiseKit version (currently it 6.8.3<7.0.0) and add a new version tag? |
Contributor
|
Hello @Vyazovoy |
|
Thanks for so quick update, @RomanPodymov! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14