Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR
When calling
fetch_users_in_org, the role information for that org member will be included at the top of the returnedUserMetadata. This information is already embedded inorg_id_to_org_info, but this provides a better DX and our BE already returns it.Notably, for every other instance of
UserMetadatarole_in_org.is_none()andadditional_roles_in_org.is_none(), so a new type may make more sense, but I decided to favor the back-compatible fix here.Tests
Verified the following in an example app:
fetch_users_in_orgtheUserMetadataincludesrole_in_org: Some("Value")andadditional_roles_in_org: Some([]).fetch_user_by_idtheUserMetadatahas the defaultrole_in_org: Noneandadditional_roles_in_org: None.