Hi @snjoetw & @shenxn !
While looking at home-assistant/core#35821 and the library https://github.com/snjoetw/py-synology ...
I propose we merge libraries !
Since we are all using the same devices, and use the same APIs !
So in one library :
- we can fetch all APIs available in our NAS (
get and post functions)
- access to already wrapped APIs:
SYNO.API.Info
SYNO.Core.SecurityScan.Status
SYNO.Core.System.Utilization
SYNO.DSM.Info
SYNO.DSM.Network
SYNO.Storage.CGI.Storage
- access to
SurveillanceStation
- access to
DownloadStation (planned to be added soon)
Benefits for Home Assistant:
- Authentication from
synology_dsm and synology (Surveillance Station) won't collide, or won't need two users
- Adding
synology_dsm will also add SurveillanceStation automatically (as a separate device)
- Users won't configure two integrations for one device (integrations params are the same besides
timeout)
- Will drastically reduce the amount of code since we just need to add & maintain a new
camera platform and avoid copy of __init__.py, config_flow.py, ... cf @home-assistant/core#35821
- @snjoetw & @shenxn could maintain the camera platform, me @Quentame the rest 😂
What do you think ?
Steps:
I personally don't have cameras linked to my DSM SurveillanceStation, but I can propose code for someone to test and open my repo so we can collaborate.
Using this library will also prevent manual payload build, from something automatic.
Cc @alexguzun (I don't forget home-assistant/core#30970)
Hi @snjoetw & @shenxn !
While looking at home-assistant/core#35821 and the library https://github.com/snjoetw/py-synology ...
I propose we merge libraries !
Since we are all using the same devices, and use the same APIs !
So in one library :
getandpostfunctions)SYNO.API.InfoSYNO.Core.SecurityScan.StatusSYNO.Core.System.UtilizationSYNO.DSM.InfoSYNO.DSM.NetworkSYNO.Storage.CGI.StorageSurveillanceStationDownloadStation(planned to be added soon)Benefits for Home Assistant:
synology_dsmandsynology(Surveillance Station) won't collide, or won't need two userssynology_dsmwill also add SurveillanceStation automatically (as a separate device)timeout)cameraplatform and avoid copy of__init__.py,config_flow.py, ... cf @home-assistant/core#35821What do you think ?
Steps:
timeoutparam@propertyto retreive API, and don't need toresetif we don't want to update them.I personally don't have cameras linked to my DSM SurveillanceStation, but I can propose code for someone to test and open my repo so we can collaborate.
Using this library will also prevent manual payload build, from something automatic.
Cc @alexguzun (I don't forget home-assistant/core#30970)