Merged
Conversation
+ add login exceptions + add Black params + add official references creation-update dates + remove useless "_sid" url prepend
+ remove _execute_get_url append_sid param
+ access error data & code + auto log after 2SA once ==> skip OTP checking + add device_token property to save connected device
20 tasks
Quentame
commented
Apr 12, 2020
Quentame
commented
Apr 12, 2020
Quentame
commented
Apr 12, 2020
Quentame
commented
Apr 12, 2020
Quentame
commented
Apr 12, 2020
Closed
Quentame
commented
Apr 12, 2020
Quentame
commented
Apr 12, 2020
| self._session_error = True | ||
| else: | ||
| self._debuglog("Failed: " + resp.text) | ||
| if json_data["error"]["code"] in {106, 107, 119}: |
Collaborator
Author
There was a problem hiding this comment.
Should we raise exceptions for common API error codes ?
Collaborator
Author
There was a problem hiding this comment.
Later on, but sure
Quentame
pushed a commit
to Quentame/python-synology
that referenced
this pull request
Aug 12, 2021
Bumps [sphinx-rtd-theme](https://github.com/readthedocs/sphinx_rtd_theme) from 0.5.0 to 0.5.1. - [Release notes](https://github.com/readthedocs/sphinx_rtd_theme/releases) - [Changelog](https://github.com/readthedocs/sphinx_rtd_theme/blob/master/docs/changelog.rst) - [Commits](readthedocs/sphinx_rtd_theme@0.5.0...0.5.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11