Merged
Conversation
Quentame
force-pushed
the
python3
branch
2 times, most recently
from
0af6dfa to
49dab77
Compare
Collaborator
Author
Quentame
commented
Oct 2, 2020
Collaborator
Author
Quentame
left a comment
Quentame
left a comment
There was a problem hiding this comment.
Should check use of u-string from Py2 unicode strings
Drop support of Python < 3.6 - remove six + future deps + usage - update deps - remove encoding - remove (object)
- pip3 super() style - remove simplejson dep + usage
Quentame
added a commit
that referenced
this pull request
Oct 18, 2020
* add syno system data and actions * add system usage examples * add upgrade information * Fix default login Exception (#73) * Migrate to Python 3.6+ (#70) * Migrate to Python 3.6+ Drop support of Python < 3.6 - remove six + future deps + usage - update deps - remove encoding - remove (object) * Fix pylint - pip3 super() style - remove simplejson dep + usage * Black format * lint setup * Travix CI py version * Use f string * Basic Typing * Revert setup version bump * correct alphabetically order * add SynoCoreUpgrade instance * simplify update_available() * correct defaults of .get() * harmonize use of API_KEY * update docs * add test data * due to #70 * update docs * solve conflict * add syno system data and actions * add system usage examples * add upgrade information * correct alphabetically order * add SynoCoreUpgrade instance * simplify update_available() * correct defaults of .get() * harmonize use of API_KEY * update docs * add test data * due to #70 * update docs * Apply suggestions from code review: function return type * Don't save previous update data Co-authored-by: Quentame <polletquentin74@me.com>
Quentame
added
Hacktoberfest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop support of Python < 3.6
Fixes #63