This repository was archived by the owner on Aug 11, 2021. It is now read-only.
Conversation
EpokK
force-pushed
the
feat/new-subscription-flow
branch
3 times, most recently
from
60ca0ff to
2851b99
Compare
EpokK
force-pushed
the
feat/new-subscription-flow
branch
from
ccba5b7 to
d66865f
Compare
EpokK
force-pushed
the
feat/new-subscription-flow
branch
from
7603e53 to
c309b7f
Compare
EpokK
force-pushed
the
feat/new-subscription-flow
branch
from
61bec68 to
c9d2ef7
Compare
econdepe
approved these changes
Jan 7, 2020
Contributor
econdepe
left a comment
econdepe
left a comment
There was a problem hiding this comment.
This was a superficial review (it's a long PR 😅). I'll try to check more in detail some core logic later
mmso
approved these changes
Jan 8, 2020
Member
mmso
left a comment
mmso
left a comment
There was a problem hiding this comment.
Some small comments, looks good otherwise 👍
mmso
reviewed
Jan 8, 2020
Yiin
approved these changes
Jan 9, 2020
Avoid to generate 2 payment tokens each time amount or currency change Fix https://jira.protontech.ch/browse/COREFE-153
…/core/react-components into feat/new-subscription-flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New components
Manager: @matstaz
VPN test server: https://vpnsettings.protonmail.blue (blue API)
Mail test server: https://settings.protonmail.blue (blue API)
Fix https://github.com/ProtonMail/react-components/issues/466
Fix https://github.com/ProtonMail/react-components/issues/464
Fix https://github.com/ProtonMail/react-components/issues/462
Fix https://github.com/ProtonMail/react-components/issues/461
Fix https://github.com/ProtonMail/react-components/issues/460