Conversation
Created TalentEntityRepository
Updated TalentRepository
Created PageConfig, that takes config from application.properties
Created ShortTalentDTO
Created TalentMapper and his impl
Created TalentService and his impl
------------
Added `GET(/api/talents)` endpoint, that returns us the `List<ShortTalentDTO>`
Added pagination to `GET(/api/talents)` endpoint
- To use pagination you may use RequestParams:
- page (gives us requested page)
- size (gives us requested size of page)
Updated TalentController
Updated TalentRepository
Created TalentEntityRepository
Created FullTalentDTO
Created TalentServiceMock
Created PageConfig, that takes config from application.properties
Created ShortTalentDTO
Created TalentMapper and his impl
Created TalentService and his impl
------------
Added `GET(/api/talents)` endpoint, that returns us the `List<ShortTalentDTO>`
Added pagination to `GET(/api/talents)` endpoint
- To use pagination you may use RequestParams:
- page (gives us requested page)
- size (gives us requested size of page)
Added simple exception handling
…at returns to us the FullTalentDTO Updated FullTalentDTO Updated TalentMapper Updated TalentService
Created pagination.properties
Maslyna
added
🐸 backend
This was
linked to
issues
Mar 21, 2023
Closed
Closed
LordRenDS
reviewed
Mar 23, 2023
LordRenDS
left a comment
LordRenDS
left a comment
There was a problem hiding this comment.
Perhaps we should modify the mapper to mapstruct, change the interfaces of the talent repository to the jpa signature.
LordRenDS
pushed a commit
that referenced
this pull request
Mar 26, 2023
Created Talent controller Created Talent service (impl and mock) Created exception handler Added pagination
LordRenDS
pushed a commit
that referenced
this pull request
Mar 26, 2023
Created Talent controller Created Talent service (impl and mock) Created exception handler Added pagination
LordRenDS
pushed a commit
that referenced
this pull request
Mar 29, 2023
Created Talent controller Created Talent service (impl and mock) Created exception handler Added pagination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request were finished next tasks: