Conversation
Denis973
added
🐸 backend
Maslyna
requested changes
Apr 19, 2023
Comment on lines
+47
to
+48
| throw new ResponseStatusException(HttpStatus.FORBIDDEN, | ||
| "Talent can give only one “kudos“ for one proof"); |
There was a problem hiding this comment.
In this point you should use 409 status code CONFLICT
Maslyna
added a commit
that referenced
this pull request
Apr 19, 2023
* Refactor: * remove Eager it Talent entity * Task#1-2 (#93) * Created Cudos entity and did some DB refactor * Created 'GET(/proofs/{proof-id}/kudos)' endpoint in KudosController * Created method 'getAmountKudosProof' in KudosService * Created KudosRepository and add 'countByProof_Id' method * Task#3 As a talent I want to estimate proofs of other talents by givi… (#96) * Task#3 As a talent I want to estimate proofs of other talents by giving "kudos" * bug fix * S3.1 us1.task 4 (#97) * Added don`t working service * @manytoone relationSHIT * Code refactor and bugfix * Transactional --------- Co-authored-by: Ren <sergeysolovyov2016@gmail.com> Co-authored-by: Ren <75202059+LordRenDS@users.noreply.github.com> Co-authored-by: Denis973 <46610112+Denis973@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng "kudos"