Merged
Conversation
schweikart
reviewed
Jun 21, 2023
Member
schweikart
left a comment
schweikart
left a comment
There was a problem hiding this comment.
Nice work, the revision of the ProcessRunner really removes a lot of boilerplate code from the solvers!
Here are a few questions about the design of the ProcessRunner that don't really change how it is used but rather aim to enforce that the ProcessRunner is used the way we designed it to be used.
schweikart
approved these changes
Jun 27, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces boilerplate code for problem solvers using external processes, like GAMS or Qiskit.
Expands the builder pattern of ProcessRunner to allow solvers to customize how they run their process.