Merged
Conversation
schweikart
requested changes
Jul 19, 2023
| @Component | ||
| public class MetaSolverFeatureModelAnomaly extends MetaSolver<FeatureModelAnomalySolver> { | ||
| public class MetaSolverFeatureModelAnomaly extends MetaSolver< | ||
| edu.kit.provideq.toolbox.featuremodel.anomaly.FeatureModelAnomalyProblem, |
Member
There was a problem hiding this comment.
Can you use an import for this??
Member
There was a problem hiding this comment.
The same thing applies to line 29, can you change this there as well?
Member
|
Can you rebase onto |
Elscrux
force-pushed
the
feat/generics-cleanup
branch
from
e00206d to
c392cc5
Compare
Member
Author
|
@schweikart I rebased the branch |
Elscrux
force-pushed
the
feat/generics-cleanup
branch
from
6c85d6e to
8a5926c
Compare
schweikart
approved these changes
Jul 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix most of the issues with raw generics.
SubRoutinePoolstill has issues with casting to the rightProblemControllerProvider. If you have an idea how to fix that, let me know @schweikart.