Refactor: split up feature model anomaly solver into different anomaly types#40
Conversation
94475db to
b7f96fd
Compare
Elscrux
left a comment
There was a problem hiding this comment.
The separate feature model solvers are much better now. Since we are using the Webflux framework now, the only real overhead of this approach is the additional meta solver, which is valid and perhaps even desired.
We might even be able to get rid of that. We could implement an |
I'd rather keep it as it is, as a |
8876daa to
729aa13
Compare
729aa13 to
b0c11b7
Compare
|
I've fixed toolbox-web to use this new route scheme in ProvideQ/toolbox-web#25 |
|
I've finally gotten to revising this PR now 😅 If this works for you now, please merge this PR into |
| * needed | ||
| */ | ||
| public record SubRoutineDefinition(ProblemType type, String url, String description) { | ||
| public record SubRoutineDefinition(ProblemType type, String description) { |
There was a problem hiding this comment.
We still need the url as part of the record. See here for its usage: https://github.com/ProvideQ/toolbox-web/blob/develop/src/components/solvers/SolverPicker.tsx#L123
What we should do here instead is only require the problem type and description in the constructor for SubRoutineDefinition so the url part can be inferred from the type.
16e2466 to
14e77fc
Compare
No description provided.