refactor: use ids for ProblemType serialization instead of enum names#44
Merged
Elscrux merged 2 commits intodocs/endpoint-documentationfrom Sep 13, 2023
Merged
Conversation
Elscrux
changed the base branch from
develop
to
docs/endpoint-documentation
Elscrux
force-pushed
the
refactor/problem-type-serialization
branch
from
4790300 to
64c9bdf
Compare
Member
Author
|
Your change makes sense to me, thank you! From my point of view, you can rebase+merge this |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that
ProblemTypes are identified through theiridattribute instead of their enum name. This decouples the names of our Java constants from the actual problem type identifiers.