Conversation
Member
Author
|
It is worth mentioning that the quality of the results of the Cirq MaxCut QAOA implementation is far from perfect. I haven't found out why the algorithm performs so poorly and we should maybe consider investigating this before releasing this solver. |
Elscrux
reviewed
Sep 13, 2023
Member
Elscrux
left a comment
There was a problem hiding this comment.
In general, this looks good. I'm pleased to see adding new solvers can be this simple now.
But for some reason, the result of our example returns everything in partition 2, which can definitely not be correct
graph [
id 42
node [
id 1
label "1"
]
node [
id 2
label "2"
]
node [
id 3
label "3"
]
edge [
source 1
target 2
]
edge [
source 2
target 3
]
edge [
source 3
target 1
]
]
Elscrux
approved these changes
Sep 14, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #19. I've decided to rebuild the cirq max-cut solver integration since we've refactored our solver setup in the last couple of weeks. With that being said, I'm happy that the integration with our new solver structure went on seamlessly :)