Skip to content

Add Cirq MaxCut solver#45

Merged
Elscrux merged 4 commits intodevelopfrom
feat/cirq-max-cut
Sep 14, 2023
Merged

Add Cirq MaxCut solver#45
Elscrux merged 4 commits intodevelopfrom
feat/cirq-max-cut

Conversation

@schweikart
Copy link
Copy Markdown
Member

Replaces #19. I've decided to rebuild the cirq max-cut solver integration since we've refactored our solver setup in the last couple of weeks. With that being said, I'm happy that the integration with our new solver structure went on seamlessly :)

@schweikart schweikart added the type: enhancement New feature or request label Sep 10, 2023
@schweikart
Copy link
Copy Markdown
Member Author

It is worth mentioning that the quality of the results of the Cirq MaxCut QAOA implementation is far from perfect. I haven't found out why the algorithm performs so poorly and we should maybe consider investigating this before releasing this solver.

@schweikart schweikart requested a review from Elscrux September 10, 2023 17:12
Copy link
Copy Markdown
Member

@Elscrux Elscrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good. I'm pleased to see adding new solvers can be this simple now.
But for some reason, the result of our example returns everything in partition 2, which can definitely not be correct

graph [
    id 42
    node [
        id 1
        label "1"
    ]
    node [
        id 2
        label "2"
    ]
    node [
        id 3
        label "3"
    ]
    edge [
        source 1
        target 2
    ]
    edge [
        source 2
        target 3
    ]
    edge [
        source 3
        target 1
    ]
]

@Elscrux Elscrux merged commit 3bf37e4 into develop Sep 14, 2023
@schweikart schweikart mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants