Skip to content

Add qubo meta solver#50

Merged
schweikart merged 7 commits intodevelopfrom
feature/qubo
Jan 2, 2024
Merged

Add qubo meta solver#50
schweikart merged 7 commits intodevelopfrom
feature/qubo

Conversation

@Elscrux
Copy link
Copy Markdown
Member

@Elscrux Elscrux commented Sep 28, 2023

Including solver using Qiskit, and a QAOA based approach

@Elscrux Elscrux requested a review from schweikart September 28, 2023 15:21
schweikart
schweikart requested changes Sep 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@schweikart schweikart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things

Comment thread src/main/java/edu/kit/provideq/toolbox/qubo/SolveQuboRequest.java Outdated
Comment thread src/main/java/edu/kit/provideq/toolbox/qubo/solvers/QiskitQuboSolver.java Outdated
Comment thread src/main/java/edu/kit/provideq/toolbox/qubo/solvers/QuboSolver.java
@schweikart
Copy link
Copy Markdown
Member

schweikart commented Nov 9, 2023

Thanks for these changes @Elscrux! Can you add JavaDocs to the QuboSolver base class too? Then this is ready to be merged :)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Elscrux Elscrux requested a review from schweikart November 9, 2023 14:09
@schweikart schweikart force-pushed the feature/qubo branch 2 times, most recently from 77910ae to d625b0b Compare January 2, 2024 14:58
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@schweikart
Copy link
Copy Markdown
Member

schweikart commented Jan 2, 2024

Had to rebase due to a conflict in qiskit/requirements.txt

schweikart
schweikart approved these changes Jan 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@schweikart schweikart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schweikart schweikart merged commit f8782be into develop Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schweikart schweikart schweikart approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Elscrux @schweikart