Show non-string solution data as json#23
Merged
schweikart merged 4 commits intodevelopfrom Jul 28, 2023
Merged
Conversation
schweikart
requested changes
Jul 19, 2023
Comment on lines
+35
to
+41
| {typeof c === "string" || c instanceof String ? ( | ||
| <pre style={{ overflowX: "auto" }}>{c}</pre> | ||
| ) : ( | ||
| <pre style={{ overflowX: "auto" }}> | ||
| {JSON.stringify(c, null, "\t")} | ||
| </pre> | ||
| )} |
Member
There was a problem hiding this comment.
you can move the ternary operator to the inside of the <pre> block
schweikart
approved these changes
Jul 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going forward, we will start using non-string solution data that can easily be integrated in other clients other than the toolbox-website. Because of this, the website needs to support non-string formats, currently by using JSON representation of any object that might be returned.
Alternatively, it would be an option to specifically request a string representation of the solution via another endpoint, or a flag we set that tells the server to return a string format.