proxmark3 refactoring command line parameters#417
Conversation
|
maybe ill add -c parameter to start proxmark command from commandline |
|
works. sample for windows: |
1. sometimes proxmark executes command twice... 2. start proxmark from QT was in a strange way( if we issue command very fast - it hangs
|
it seems) all is ok ready for test and merge |
|
Nice changes, Great changes, some I recognise and some interesting new ones. However, it would be great if you could make small, simple PR. Which is easy to test out and not add more commits and functionality as it goes. Otherwise it is gonna take even longer to test the PR. To conclude, please,
|
|
ok) now it ready. |
client/proxmark3.c
Outdated
|
|
||
| // dont execute comamnds in offline mode | ||
| if (offline && (executeCommand || script_cmds_file)) { | ||
| printf("ERROR: can't execute in offline mode.\n"); |
There was a problem hiding this comment.
Please remove. There are commands which can be executed in offline mode.
|
dont execute commands. deleted |
|
question, now that you added the "-c" param, what is actually needed for us to use pipe:ing ? I believe this will make the pm3 client much friendler to use in shellscripts, or other scripts |
|
https://stackoverflow.com/questions/15467164/why-does-readline-echo-stdin-to-stdout |
printf "hf 14a reader\nhf mf rdbl 0 a ffffffffffff\n" | proxmark3 com6 -w needs refactoring
|
Pipe works, on win/linux/osx ? nicely done! |
|
works. try |
|
Works fine on Windows and Kali. Passes Travis Tests. Please add a line to CHANGELOG.md |
|
added |
small refactoring + added feature to wait com port on proxmark start