Skip to content

proxmark3 refactoring command line parameters#417

Merged
pwpiwi merged 19 commits intoProxmark:masterfrom
merlokk:cmds
Oct 20, 2017
Merged

proxmark3 refactoring command line parameters#417
pwpiwi merged 19 commits intoProxmark:masterfrom
merlokk:cmds

Conversation

@merlokk
Copy link
Contributor

@merlokk merlokk commented Oct 13, 2017

small refactoring + added feature to wait com port on proxmark start

@merlokk
Copy link
Contributor Author

merlokk commented Oct 13, 2017

maybe ill add -c parameter to start proxmark command from commandline

@merlokk
Copy link
Contributor Author

merlokk commented Oct 13, 2017

works.
It needs to check. Many changes in ifdef code(....

sample for windows:

proxmark3.exe com6 -w -c "hf mf nested 1 *"
proxmark3.exe com6 -w -c "hf mf chk 1* ?"
proxmark3.exe com6 -c "script run hf_read"

1. sometimes proxmark executes command twice...
2. start proxmark from QT was in a strange way( if we issue command very fast - it hangs
@merlokk
Copy link
Contributor Author

merlokk commented Oct 13, 2017

it seems) all is ok

proxmark3.exe com6 -w -c "hf mf nested 1 *"
proxmark3.exe com6 -c "hf mf chk 1* ?"
proxmark3.exe com6 -l hf_read

ready for test and merge

@iceman1001
Copy link
Member

iceman1001 commented Oct 13, 2017

Nice changes, Great changes, some I recognise and some interesting new ones.

However, it would be great if you could make small, simple PR. Which is easy to test out and not add more commits and functionality as it goes. Otherwise it is gonna take even longer to test the PR.

To conclude, please,

  • Don't make a PR if your change is not ready to be commited.
  • Don't add commits over and over.
  • test your own code before making PR
  • one new functionality / PR is helpful

@merlokk
Copy link
Contributor Author

merlokk commented Oct 13, 2017

ok) now it ready.
I will publish next PR after i have tested changes.


// dont execute comamnds in offline mode
if (offline && (executeCommand || script_cmds_file)) {
printf("ERROR: can't execute in offline mode.\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove. There are commands which can be executed in offline mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

@merlokk
Copy link
Contributor Author

merlokk commented Oct 15, 2017

dont execute commands. deleted

@iceman1001
Copy link
Member

question, now that you added the "-c" param, what is actually needed for us to use pipe:ing ?
like this:
echo "hf 14a reader" | proxmark3 -w

I believe this will make the pm3 client much friendler to use in shellscripts, or other scripts

@merlokk
Copy link
Contributor Author

merlokk commented Oct 17, 2017

https://stackoverflow.com/questions/15467164/why-does-readline-echo-stdin-to-stdout
The readline library is solely intended for interactive use
ill make it by getline()...

printf "hf 14a reader\nhf mf rdbl 0 a ffffffffffff\n" | proxmark3 com6  -w

needs refactoring
@iceman1001
Copy link
Member

Pipe works, on win/linux/osx ? nicely done!

@merlokk
Copy link
Contributor Author

merlokk commented Oct 18, 2017

works. try
win:
printf "hf 14a reader\nhf mf rdbl 0 a ffffffffffff\n" | proxmark3 comX -w

@pwpiwi
Copy link
Contributor

pwpiwi commented Oct 19, 2017

Works fine on Windows and Kali. Passes Travis Tests.

Please add a line to CHANGELOG.md

@merlokk
Copy link
Contributor Author

merlokk commented Oct 19, 2017

added

@pwpiwi pwpiwi merged commit aa757f7 into Proxmark:master Oct 20, 2017
iceman1001 added a commit to iceman1001/proxmark3 that referenced this pull request Oct 20, 2017
@merlokk merlokk deleted the cmds branch October 26, 2017 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants