Add systemd-rpm-macros to Docker build images #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the systemd-rpm-macros package to all RHEL-based and OpenSUSE-based Docker build images. This is required for proper RPM package uninstallation on Amazon Linux 2023 and other systemd-based RHEL distributions, as the %systemd_preun macro in the RPM spec files requires this package to be available in the build environment. Fixes #15 Related to: - ProxySQL issue sysown/proxysql#5335 - ProxySQL PR sysown/proxysql#5336
Collaborator
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Pull request overview
This PR updates all active RHEL-like (CentOS Stream, AlmaLinux, Amazon Linux, Fedora) and openSUSE build Docker images to include systemd-rpm-macros, ensuring %systemd_preun and related macros are available during RPM build/uninstall operations.
Changes:
- Added
systemd-rpm-macrosto all yum/dnf/zypper-based build-tool install steps for RHEL-family images (CentOS Stream, AlmaLinux, Amazon Linux, Fedora). - Added
systemd-rpm-macrosto openSUSE Leap 15.6 and 16.0 build images viazypper. - Updated both experimental Amazon Linux 2 and Amazon Linux 2023 build images to include
systemd-rpm-macrosin their base toolchains.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build-images/experimental/build-amazon2023/Dockerfile | Adds systemd-rpm-macros to the Amazon Linux 2023 yum-installed build toolchain to support systemd RPM macros. |
| build-images/experimental/build-amazon2/Dockerfile | Adds systemd-rpm-macros to the Amazon Linux 2 yum-installed build toolchain. |
| build-images/build-opensuse16/Dockerfile | Extends the zypper-installed compiler/toolchain set with systemd-rpm-macros on openSUSE Leap 16.0. |
| build-images/build-opensuse15/Dockerfile | Extends the zypper-installed compiler/toolchain set with systemd-rpm-macros on openSUSE Leap 15.6. |
| build-images/build-fedora43/Dockerfile | Adds systemd-rpm-macros to the Fedora 43 dnf-installed build tools. |
| build-images/build-fedora42/Dockerfile | Adds systemd-rpm-macros to the Fedora 42 dnf-installed build tools. |
| build-images/build-fedora41/Dockerfile | Adds systemd-rpm-macros to the Fedora 41 dnf-installed build tools. |
| build-images/build-centos9/Dockerfile | Adds systemd-rpm-macros to the CentOS Stream 9 yum-installed build tools. |
| build-images/build-centos10/Dockerfile | Adds systemd-rpm-macros to the CentOS Stream 10 yum-installed build tools. |
| build-images/build-almalinux9/Dockerfile | Adds systemd-rpm-macros to the AlmaLinux 9 yum-installed build tools. |
| build-images/build-almalinux8/Dockerfile | Adds systemd-rpm-macros to the AlmaLinux 8 yum-installed build tools. |
| build-images/build-almalinux10/Dockerfile | Adds systemd-rpm-macros to the AlmaLinux 10 yum-installed build tools. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📝 WalkthroughWalkthroughThe PR adds the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the systemd-rpm-macros package to all RHEL-based and OpenSUSE-based Docker build images. This is required for proper RPM package uninstallation on Amazon Linux 2023 and other systemd-based RHEL distributions, as the %systemd_preun macro in the RPM spec files requires this package to be available in the build environment.
Changes
Related Issues
The changes are minimal and focused, only adding the required dependency without modifying any other functionality. All Dockerfiles maintain their existing structure and formatting.
Summary by CodeRabbit