Skip to content

fix: enhance algorithm group management in SmashConfig when loading old configs#119

Merged
davidberenstein1957 merged 3 commits intofeat/qkv_fusing_and_fp8_quantizationfrom
fix/116-bug-can-not-load-a-prunamodel-from-hub-because-smash_config-does-not-contain-the-new-family-of-algo
May 15, 2025
Merged

fix: enhance algorithm group management in SmashConfig when loading old configs#119
davidberenstein1957 merged 3 commits intofeat/qkv_fusing_and_fp8_quantizationfrom
fix/116-bug-can-not-load-a-prunamodel-from-hub-because-smash_config-does-not-contain-the-new-family-of-algo

Conversation

@davidberenstein1957
Copy link
Copy Markdown
Member

@davidberenstein1957 davidberenstein1957 commented May 15, 2025

Description

This should align the config keys we pass to the ConfigSpace, with the actually available algorithms and warn or inform if that is not the case.

Related Issue

Fixes #116

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@davidberenstein1957 davidberenstein1957 requested a review from llcnt May 15, 2025 08:55
@davidberenstein1957 davidberenstein1957 mentioned this pull request May 15, 2025
Merged
10 tasks
@davidberenstein1957 davidberenstein1957 changed the title feat: enhance algorithm group management in SmashConfig feat: enhance algorithm group management in SmashConfig when loading models May 15, 2025
@davidberenstein1957 davidberenstein1957 changed the title feat: enhance algorithm group management in SmashConfig when loading models fix: enhance algorithm group management in SmashConfig when loading models May 15, 2025
@davidberenstein1957 davidberenstein1957 changed the title fix: enhance algorithm group management in SmashConfig when loading models fix: enhance algorithm group management in SmashConfig when loading old configs May 15, 2025
@davidberenstein1957 davidberenstein1957 linked an issue May 15, 2025 that may be closed by this pull request
[BUG] Can not load a Prunamodel from hub because smash_config does not contain the new family of algo #116
Closed
llcnt
llcnt approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@llcnt llcnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) elegant way for solving the issue!

@davidberenstein1957 davidberenstein1957 merged this pull request into feat/qkv_fusing_and_fp8_quantization May 15, 2025
@johannaSommer johannaSommer deleted the fix/116-bug-can-not-load-a-prunamodel-from-hub-because-smash_config-does-not-contain-the-new-family-of-algo branch May 19, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llcnt llcnt llcnt approved these changes

@sharpenb sharpenb Awaiting requested review from sharpenb

@nifleisch nifleisch Awaiting requested review from nifleisch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Can not load a Prunamodel from hub because smash_config does not contain the new family of algo

2 participants

@davidberenstein1957 @llcnt