-
Notifications
You must be signed in to change notification settings - Fork 77
refactor: formalize artifact saving #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment @cursor review or bugbot run to trigger another review on this PR
llcnt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, this is a very cool feature :) (I was personally doing a custom save/load artifacts in my ongoing PR )
simlang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Thanks for taking care of that, super useful for literally everything 🚀
Just had a question about the backward compatibility
| if SAVE_FUNCTIONS.torch_artifacts.name in smash_config.save_fns: | ||
| save_torch_artifacts(model, model_path, smash_config) | ||
| smash_config.save_fns.remove(SAVE_FUNCTIONS.torch_artifacts.name) | ||
| # Backward compatibility with torch artifacts save function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see why this is necessary, but it would be nice to remove this as soon as possible again - should we add a deprecation warning or something, and then actually remove it again at some point?
4bcb4cd to
87a422d
Compare
Description
Formalize artifact saving and expose it to more algorithms, and add artifact hooks into Smash config
Type of Change
How Has This Been Tested?
Checklist
Additional Notes