Add compatibility layer for 0.6.3 mods in 1.0.4 #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 43694ff.
lspepinho
changed the title
Collaborator
|
This might be peak |
Author
|
This is peak. |
Collaborator
|
You need to update your branch with the dev version |
Author
|
oh, imma do it |
mikolka9144
requested changes
Oct 8, 2025
Collaborator
mikolka9144
left a comment
mikolka9144
left a comment
There was a problem hiding this comment.
Looks mostly good, just please revert unnecessary changes intorduced in your PR
Author
There was a problem hiding this comment.
oh, i accidentally merged the latest p-slice
Collaborator
There was a problem hiding this comment.
Not sure what happened here, but could you revert this change?
| { | ||
| public function new(x:Float, y:Float) | ||
| { | ||
| super(x, y, "charSelect/bfChill"); |
Collaborator
There was a problem hiding this comment.
I belive this could break some things outside of the Psych 0.6.3 compatiblity
Collaborator
There was a problem hiding this comment.
If I remember correctly this class was moved, so no point in adding it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds simple backwards compatibility support, exactly as described from Fixing Lua Mods from 0.6.x to 1.0 in the original (now archived) PsychEngine repository