Fix review workflow: add engine:copilot block and workflow_dispatch#594
Fix review workflow: add engine:copilot block and workflow_dispatch#594
Conversation
The review.agent.md was missing the engine: block needed for the Copilot agent runtime to process the workflow. Added: - engine: id: copilot, model: claude-sonnet-4.6 - workflow_dispatch with pr_number input for manual triggering - Top-level if: condition for event filtering Modeled after dotnet/maui's copilot-evaluate-tests.md format. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add engine: id: copilot block (required for agent runtime) - Add workflow_dispatch with pr_number input - Compile with gh aw compile to generate .lock.yml - Remove pull_request trigger (can't combine with slash_command) - Remove issues:write and label management (gh-aw strict mode) - Permissions are read-only; writes go through safe-outputs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copies the gh-aw (GitHub Agentic Workflows) instructions file from dotnet/maui. Covers: anti-patterns, execution model, security boundaries, fork handling, compilation, safe-outputs patterns, and troubleshooting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
gh-aw safe-output keys must use hyphens (kebab-case), not underscores. The compiler normalizes them to underscores in the lock file. Using underscores in the source caused the compiler to silently drop them, resulting in no PR review tools in the compiled workflow. Reverts the underscore change from PR #593 commit 10 — msbuild's original hyphenated format was correct. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🔍 Multi-Model Code Review — PR #594PR: Fix review workflow: add engine:copilot block and workflow_dispatch 🔴 CRITICAL (found and fixed during review)Safe-output keys must use hyphens, not underscoresFlagged by: 2/3 reviewers, confirmed by recompilation PR #593 commit 10 changed safe-output keys from hyphens to underscores. This caused Root cause: gh-aw expects hyphens (kebab-case) in source Fix applied: Reverted to hyphens in commit ✅ Verified Correct
🟢 MINORDescription says "automatically" but auto-trigger is removedFlagged by: 1/3 reviewers The workflow description still says "automatically for trusted contributors" but Recommended Action✅ Approve — the critical safe-outputs issue was found and fixed during this review. All changes are now correct and the workflow compiles cleanly with all required tools. |
The
review.agent.mdwas missing theengine:block needed for the Copilot agent runtime to process the workflow. Without it, the/reviewslash command and auto-triggers weren't being picked up.Changes:
engine: id: copilot, model: claude-sonnet-4.6— tells the platform to use the Copilot agent runtimeworkflow_dispatchwithpr_numberinput for manual triggeringif:condition for event filteringModeled after
dotnet/maui'scopilot-evaluate-tests.mdformat.