Skip to content

chore: consolidate all skills into .claude/skills/#753

Merged
PureWeen merged 1 commit intomainfrom
fix/consolidate-skills
Apr 23, 2026
Merged

chore: consolidate all skills into .claude/skills/#753
PureWeen merged 1 commit intomainfrom
fix/consolidate-skills

Conversation

@PureWeen
Copy link
Copy Markdown
Owner

Moves gh-aw-guide and instruction-drift skills from .github/skills/ to .claude/skills/ so all 11 skills live in one directory. Updated all internal references and recompiled the instruction-drift workflow lock file.

Move gh-aw-guide and instruction-drift skills from .github/skills/
to .claude/skills/ so all skills live in one directory. Updated all
internal references in workflows, sync manifest, and skill docs.
Recompiled instruction-drift workflow lock file.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@PureWeen PureWeen merged commit fa8917c into main Apr 23, 2026
3 checks passed
@PureWeen PureWeen deleted the fix/consolidate-skills branch April 23, 2026 16:45
@github-actions
Copy link
Copy Markdown
Contributor

Design-Level Findings (outside diff hunks)

These findings affect files that were renamed without content changes, so inline comments are not possible.


🟡 MODERATE — Stale default watermark path in Scan-GhAwUpdates.ps1

File: .claude/skills/instruction-drift/scripts/Scan-GhAwUpdates.ps1, line ~36

[string]$WatermarkFile = ".github/skills/gh-aw-guide/.gh-aw-watermark.json",

The default $WatermarkFile parameter still points to .github/skills/gh-aw-guide/, which was deleted by this PR. When the workflow calls this script without an explicit -WatermarkFile argument, it will attempt to read/write the watermark at a nonexistent location — either silently re-creating the old directory structure or failing with $ErrorActionPreference = 'Stop'.

Fix: Change default to .claude/skills/gh-aw-guide/.gh-aw-watermark.json

Flagged by: 3/3 reviewers


🟢 MINOR — Stale path in architecture.md anti-pattern example

File: .claude/skills/gh-aw-guide/references/architecture.md, line ~302

The "DANGEROUS" anti-pattern example still uses run: pwsh .github/skills/some-script.ps1. Now that scripts live in .claude/skills/, this could mislead someone writing a new workflow step.

Fix: Update to .claude/skills/some-script.ps1 or use a clearly fictional path.

Flagged by: 2/3 reviewers


🟢 MINOR — Example manifest in SKILL.md shows old relative target

File: .claude/skills/instruction-drift/SKILL.md, line ~82

The example YAML block within the SKILL.md documentation still shows target: ../skills/gh-aw-guide/SKILL.md (the old relative path). Future manifests copied from this example would inherit the same broken path from Finding #1.

Fix: Update the example to use ../../.claude/skills/... to match the corrected manifest.

Flagged by: 2/3 reviewers

Generated by Expert Code Review (auto) for issue #753 · ● 8.6M ·

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated by Expert Code Review (auto) for issue #753 · ● 8.6M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant