Skip to content

Specify output_file encoding as utf-8 #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericwb merged 4 commits into from
Dec 14, 2020
Merged

Specify output_file encoding as utf-8 #364

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c185f38
Specify output_file encoding as utf-8
Brcrwilliams Aug 11, 2018
494650d
Merge branch 'master' into encoding
ericwb Jan 12, 2020
99c792d
Merge branch 'master' into encoding
lukehinds Mar 7, 2020
dd1ef38
Merge branch 'master' into encoding
ericwb Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bandit/cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def main():
)
parser.add_argument(
'-o', '--output', dest='output_file', action='store', nargs='?',
type=argparse.FileType('w'), default=sys.stdout,
type=argparse.FileType('w', encoding='utf-8'), default=sys.stdout,
Copy link
Copy Markdown
Member

@ericwb ericwb Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The encoding parameter wasn't added until Py3.4, but we still want to support Py2.7 at this point.

https://docs.python.org/3/library/argparse.html#filetype-objects

help='write report to filename'
)
group = parser.add_mutually_exclusive_group(required=False)
Expand Down