Detect misuse of psycopg2.sql.SQL composable#608
Open
wtkm11 wants to merge 12 commits into
Open
Conversation
Add a plugin test to detect when something other than a string literal is passed to the constructor of the `psycopg2.sql.SQL` composable object. Resolves: PyCQA#412
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
reviewed
Jul 12, 2022
ericwb
requested changes
Jul 14, 2022
Member
ericwb
left a comment
ericwb
left a comment
There was a problem hiding this comment.
This solution is specific to psycopg2. I'd rather see a fix that can reuse the existing general SQL statements plugin to detect this particular case.
ericwb
reviewed
Apr 9, 2023
|
This plugin needs to be updated so that it works for @ericwb The general plugin If consensus can't be reached on merging this plugin into bandit, then it should be released as a separate package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a plugin test to detect when something other than a string literal is passed to the constructor of the
psycopg2.sql.SQLcomposable object.See issue #412
Closes #412